fix: use auth_client_required instead of removed auth_supported for RBD - #13991
Open
waterWang wants to merge 1 commit into
Open
fix: use auth_client_required instead of removed auth_supported for RBD#13991waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Ceph Tentacle 20.2.4 removed the legacy `auth_supported` librados option. CloudStack builds RBD connection strings with `auth_supported=cephx`/`none`, so every RBD operation through the KVM agent fails with "failed to set RADOS option: auth_supported". Switch the RBD string builder to `auth_client_required`, the modern option used by the qemu rbd driver and accepted by current Ceph releases.
Member
|
@waterWang have you verified the changes ? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13991 +/- ##
============================================
- Coverage 19.73% 19.73% -0.01%
+ Complexity 19959 19958 -1
============================================
Files 6371 6371
Lines 575784 575784
Branches 70478 70478
============================================
- Hits 113653 113639 -14
- Misses 449778 449798 +20
+ Partials 12353 12347 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13989
Problem
CloudStack builds its RBD connection strings with the legacy Ceph option
auth_supported=cephx(orauth_supported=nonewhen no auth user is configured). This option was removed in Ceph Tentacle 20.2.4. As a result, every RBD operation performed by the KVM agent through librados fails:Root cause
KVMPhysicalDisk.RBDStringBuilderemitsauth_supportedin the RBD URI string passed to qemu/librados. Modern librados no longer accepts this option name.Fix
Replace
auth_supportedwithauth_client_required(valuescephx/none) — the modern option used by the qemu rbd driver (block/rbd.ccallsrados_conf_set(cluster, "auth_client_required", ...)) and accepted by current Ceph releases. The qemuRbdAuthModeenum only supportscephxandnone, matching the existing branches.Changes
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java: emitauth_client_required=cephx/auth_client_required=noneplugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/KVMPhysicalDiskTest.java: update 3 assertions to expectauth_client_required=cephx