Skip to content

fix: SSVM entity download URL creation: ensure userdata base dir exists and is writable by www-data #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: SSVM entity download URL creation: ensure userdata base dir exists and is writable by www-data #13967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...torage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,24 @@ public CreateEntityDownloadURLAnswer handleCreateEntityURLCommand(CreateEntityDo
// Create the directory structure so that its visible under apache server root
String extractDir = BASE_EXTRACT_PATH;
extractDir = extractDir + cmd.getFilepathInExtractURL() + File.separator;
// Ensure the base extract directory exists and is owned by www-data so that
// the www-data user can create the per-entity subdirectory inside it.
Script baseDirCommand = new Script("/bin/bash", logger);
baseDirCommand.add("-c");
baseDirCommand.add("mkdir -p " + BASE_EXTRACT_PATH + " && chown www-data:www-data " + BASE_EXTRACT_PATH);
String result = baseDirCommand.execute();
if (result != null) {
String errorString = "Error in creating base extract directory =" + result;
logger.error(errorString);
return new CreateEntityDownloadURLAnswer(errorString, CreateEntityDownloadURLAnswer.RESULT_FAILURE);
}
Script command = new Script("/bin/su", logger);
command.add("-s");
command.add("/bin/bash");
command.add("-c");
command.add("mkdir -p " + extractDir);
command.add("www-data");
String result = command.execute();
result = command.execute();
if (result != null) {
String errorString = "Error in creating directory =" + result;
logger.error(errorString);
Expand Down