MINOR: Don't install Homebrew's aws-sdk-cpp and gRPC for JNI macOS build - #1269
Open
jbonofre wants to merge 1 commit into
Open
MINOR: Don't install Homebrew's aws-sdk-cpp and gRPC for JNI macOS build#1269jbonofre wants to merge 1 commit into
jbonofre wants to merge 1 commit into
Conversation
The "JNI macos-15-intel x86_64" job fails in "Install dependencies":
##[error]aws-sdk-cpp: no bottle available!
##[error]grpc: no bottle available!
`brew bundle` failed! 2 Brewfile dependencies failed to install
Homebrew treats x86_64 macOS as a tier 3 configuration and rarely
publishes bottles for it. "brew bundle" doesn't build from source, so
arrow/cpp/Brewfile can no longer be installed as-is.
We don't use Homebrew's aws-sdk-cpp and gRPC anyway. The JNI build uses
ARROW_DEPENDENCY_USE_SHARED=OFF and Homebrew provides only shared
libraries for them, so we uninstall both just after "brew bundle". We
skip installing them with HOMEBREW_BUNDLE_BREW_SKIP instead of
installing and uninstalling them.
"brew uninstall aws-sdk-cpp" needs "|| :" now because it's no longer
installed by "brew bundle". It's still called because it may be
pre-installed on GitHub Actions runner images.
jbonofre
requested review from
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
August 28, 2026 13:22
Member
Author
|
@lidavidm this PR is about a CI failure I observed. |
lidavidm
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
JNI macos-15-intel x86_64job in the RC workflow fails inInstall dependencies, before anything is built:Homebrew treats x86_64 macOS as a tier 3 configuration and rarely publishes bottles for it.
brew bundledoesn't build from source, soarrow/cpp/Brewfilecan no longer be installed as-is there.This breaks
maintoo, not just PRs, so nightly RC runs are red.What changes are included in this PR?
We don't use Homebrew's
aws-sdk-cppand gRPC anyway:ninja-release-jni-macospreset, which setsARROW_DEPENDENCY_USE_SHARED=OFF.aws-sdk-cppand gRPC.brew bundleto ensure the bundled ones are used.We skip installing them with
HOMEBREW_BUNDLE_BREW_SKIPinstead of installing and uninstalling them. This also makes themacos-14aarch_64job a bit faster because it no longer installs two formulae it immediately removes.brew uninstall aws-sdk-cppneeds|| :now because it's no longer installed bybrew bundle. It's still called because it may be pre-installed on GitHub Actions runner images.Note that this keeps building the x86_64 macOS shared libraries. Dropping the
macos-15-intelentry would remove.dylibfiles for x86_64 macOS from our release JARs, which needs a separate discussion.Are these changes tested?
Yes, by CI. The
JNI macos-15-intel x86_64andJNI macos-14 aarch_64jobs in this PR exercise the changed step.Are there any user-facing changes?
No.