Skip to content

[v3-4-test] Stop labelling fork CI PRs that change CI files for workflow approval (#76289) - #76582

Merged
shahar1 merged 1 commit into
apache:v3-4-testfrom
shahar1:backport-76289-v3-4-test
Nov 6, 2026
Merged

shahar1 merged 1 commit into
apache:v3-4-testfrom
shahar1:backport-76289-v3-4-test

Conversation

@shahar1

@shahar1 shahar1 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Backport of #76289 to v3-4-test, cherry-picked from 4c110e6 (cherry-pick conflict-free).

A pull request whose CI runs in the contributor's fork gets its project CI runs held when it changes CI definition files. It got the need workflow approval label for that, and needs project ci once its fork run was green. Without use project ci, approving the held runs does not start project CI, so the first label asked maintainers for a step that does not help. This change stops labelling those pull requests.

#76282 builds on this change and is backported in #76394, which currently carries this commit too and will be rebased once this PR merges.

related: #76289, #76394


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Sonnet 5.5)

Generated-by: Claude Code (Claude Sonnet 5.5) following the guidelines

🤖 Generated with Claude Code

https://claude.ai/code/session_01BVx6gAsN7oymTNMwJp1Xvm

…apache#76289)

A pull request whose CI runs in the contributor's fork gets its
project CI runs held when it changes CI definition files. It got the
"need workflow approval" label for that, and "needs project ci" once
its fork run was green. Without "use project ci", approving the held
runs does not start project CI, so the first label asked maintainers
for a step that does not help. It also stayed on pull requests whose
fork run failed.

(cherry picked from commit 4c110e6)
@shahar1
shahar1 enabled auto-merge (squash) November 6, 2026 08:10
@shahar1
shahar1 merged commit ea9416d into apache:v3-4-test Nov 6, 2026
119 checks passed
vatsrahul1001 pushed a commit that referenced this pull request Nov 9, 2026
…#76289) (#76582)

A pull request whose CI runs in the contributor's fork gets its
project CI runs held when it changes CI definition files. It got the
"need workflow approval" label for that, and "needs project ci" once
its fork run was green. Without "use project ci", approving the held
runs does not start project CI, so the first label asked maintainers
for a step that does not help. It also stayed on pull requests whose
fork run failed.

(cherry picked from commit 4c110e6)

Co-authored-by: Andrew Chang <69671930+Andrushika@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants