Repository navigation
[v3-4-test] Stop labelling fork CI PRs that change CI files for workflow approval (#76289) - #76582
Merged
Merged
Conversation
…apache#76289) A pull request whose CI runs in the contributor's fork gets its project CI runs held when it changes CI definition files. It got the "need workflow approval" label for that, and "needs project ci" once its fork run was green. Without "use project ci", approving the held runs does not start project CI, so the first label asked maintainers for a step that does not help. It also stayed on pull requests whose fork run failed. (cherry picked from commit 4c110e6)
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
November 6, 2026 08:09
shahar1
enabled auto-merge (squash)
November 6, 2026 08:10
Merged
1 task done
vatsrahul1001
pushed a commit
that referenced
this pull request
Nov 9, 2026
…#76289) (#76582) A pull request whose CI runs in the contributor's fork gets its project CI runs held when it changes CI definition files. It got the "need workflow approval" label for that, and "needs project ci" once its fork run was green. Without "use project ci", approving the held runs does not start project CI, so the first label asked maintainers for a step that does not help. It also stayed on pull requests whose fork run failed. (cherry picked from commit 4c110e6) Co-authored-by: Andrew Chang <69671930+Andrushika@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76289 to
v3-4-test, cherry-picked from 4c110e6 (cherry-pick conflict-free).A pull request whose CI runs in the contributor's fork gets its project CI runs held when it changes CI definition files. It got the
need workflow approvallabel for that, andneeds project cionce its fork run was green. Withoutuse project ci, approving the held runs does not start project CI, so the first label asked maintainers for a step that does not help. This change stops labelling those pull requests.#76282 builds on this change and is backported in #76394, which currently carries this commit too and will be rebased once this PR merges.
related: #76289, #76394
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Sonnet 5.5) following the guidelines
🤖 Generated with Claude Code
https://claude.ai/code/session_01BVx6gAsN7oymTNMwJp1Xvm