Repository navigation
Conversation
|
Your CI change needs a maintainer. CI for this pull request runs in your fork, and the workflow runs it starts in apache/airflow are approved automatically while they only run the fork CI gate. This pull request changes files that define what CI runs:
Such a change can make project CI run on the project's runners, so its workflow runs in apache/airflow wait for a maintainer to review the change and approve them. CI in your fork is not affected, and its result stays visible on this pull request. Pull requests from contributors run their CI in the contributor's own fork. GitHub Actions is free and has no minute limit on public forks, while the CI capacity of the Apache Software Foundation is shared by every ASF project and is finite. This comment was posted automatically by the fork CI monitor from templates drafted with an AI-assisted tool, so it may contain mistakes. An Apache Airflow maintainer, a real person, will review the pull request once its fork CI is green. Why the first pass is automated. |
|
Project CI in use. A maintainer added the This comment was posted automatically by the fork CI monitor from templates drafted with an AI-assisted tool, so it may contain mistakes. An Apache Airflow maintainer, a real person, will review the pull request once its fork CI is green. Why the first pass is automated. |
9435bf2 to
76cc488
Compare
A job whose condition uses a status function such as `!cancelled()` still skips in forks when the condition also requires a guarded job it needs to have succeeded, as `trigger-upgrade-check` in mirror-hardened-base-images.yml does, so the check no longer reports it. The docstring also no longer says ci-arm.yml runs in forks on push. Generated-by: Claude Opus 5
76cc488 to
a2530df
Compare
potiuk
left a comment
There was a problem hiding this comment.
Thanks - the rules for needs: and status functions match how GitHub skips jobs. I rebased the branch on main and pushed a fixup (a2530df) instead of asking for another round:
- Rebased on
main: the branch was 389 commits behind, andmainhas since gained a scheduled job (trigger-upgrade-checkinmirror-hardened-base-images.yml, from #76225) that the hook reported although it skips in forks: its condition starts with!cancelled()but also requires the guardedbuild-infoto succeed. scripts/ci/prek/check_scheduled_workflows_skip_forks.py: a job whose condition usesalways(),cancelled()orfailure()now passes when the condition also requires a covered job it needs to succeed (needs.<job>.result == 'success'). The hook passes on every workflow on currentmain.scripts/tests/ci/prek/test_check_scheduled_workflows_skip_forks.py: three cases for that shape - a required covered parent, a required uncovered parent, and a required job the job does not need.- The module docstring no longer says
ci-arm.ymlruns in forks on push: it has onlyscheduleandworkflow_dispatch, and both exempt workflows rely oncheck-run-neededto skip scheduled runs in forks.
As the change touches CI files, I also added use project ci so project CI verifies it.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Airflow handles maintainer review:
Contributing guide.
Appreciate the review as always. Thanks for pushing the fixup as well! |
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
…orks (#76267) (#77104) * Add a prek hook to keep scheduled workflows skipping in forks * Accept a scheduled job that requires a guarded job to succeed A job whose condition uses a status function such as `!cancelled()` still skips in forks when the condition also requires a guarded job it needs to have succeeded, as `trigger-upgrade-check` in mirror-hardened-base-images.yml does, so the check no longer reports it. The docstring also no longer says ci-arm.yml runs in forks on push. Generated-by: Claude Opus 5 --------- (cherry picked from commit 71f6e9b) Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
* [v3-4-test] Sync fork CI changes from main Several fork CI changes merged to main since the last sync never reached v3-4-test, and the fork CI monitor reads the gate configuration of a pull request's base branch, so pull requests to v3-4-test were still closed after 7 days and missed ten pilot participants. The fork CI modules, their tests, the design document and its diagrams, the monitor workflow, the gate configuration checks and the contributor documentation now match main, taking in #75814, #75696, #76272, #76316, #76327, #76510, #76538, #76677, #76681, #76835, #76836, #76837, #76839, #76841, #76866, #76267 and #77100. The pilot participants new to this branch join at 2026-11-16 00:00 UTC rather than at their main dates, as the gate configuration check requires a future instant for an entry that is new on the base branch. Generated-by: Claude Opus 5 * [v3-4-test] Say the fork CI monitor runs every 5 minutes in the CI tasks doc The sentence changed with #76836 on main and was missed by the sync. Generated-by: Claude Opus 5 * [v3-4-test] Bring the fork CI GitHub client tests in line with main The tests for the smaller job listing pages (#76327) were missed by the sync; the client code they cover is already in it. Generated-by: Claude Opus 5
#76243 Added a guard to skip scheduled workflows in forks that enable Actions. This is a follow up PR that adds a
prekhook to ensure any new scheduled workflows get the same guard. A job passes when its ownif:has theapache/airflowguard, or when it needs a job that passes it and doesn't override the skip withalways(),cancelled()orfailure().Couple of notes worth mentioning - The
ci-amd.ymlandci-arm.ymlfiles exempt since they need to run in forks on push, and theircheck-run-neededstep already skips scheduled runs there. The check is textual so it catches a missing guard, but a guard ORed with something thats true in forks (like github.event_name == 'schedule' || ...) would still pass. None of the current workflows do that anyway and I don't think it's worth the additional complexity of trying to account for that.Example (I modified some of the files locally to intentionally fail it):

Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.