Conversation
Dev-iL
requested review from
amoghrajesh,
ashb,
dstandish and
kaxil
as code owners
September 20, 2026 18:21
Dev-iL
force-pushed
the
2609/async_secrets
branch
3 times, most recently
from
September 21, 2026 10:49
510d12c to
d86dcce
Compare
Keep async test connections on the loop that opened them The metastore async test imported `AsyncSession` by name before reconfiguring, so it kept using the previous engine and left pooled connections bound to a closed loop for later tests to trip over.
The Execution API variable route now resolves values through resolve_variable instead of Variable.get, so the test's injected RuntimeError never fired and the request fell through to a 404. Inject the fault at the call the route actually makes so the test exercises the exception path it was written for.
Slow secret decoding and masking must not stall other requests. Dag parsing uses its own event loop, so its async connections must stay separate from the API server's global pool.
Dev-iL
force-pushed
the
2609/async_secrets
branch
from
October 1, 2026 14:21
d86dcce to
b464fc0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #67799, #72329
Execution API
VariableandConnectionreads previously depended on synchronous core resolvers, preventing the server from using native async backend I/O. This change adds async server-side resolution while preserving the existing secrets backend configuration, ordering, and behavior:aget_variableandaget_connectiondispatch.TestClientevent loop, preventing pooled MySQL connections from crossing loop lifetimes.Native cloud-provider clients remain follow-up work, separate from the SDK Variable API work in #72329.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.