Add Wait.waitFor() overload for just error msg - #6572
Merged
Merged
Conversation
dlmarion
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
waitFor()overload that accepts the wait condition and an error message. Before this change, if we wanted to add an error message, we needed to use the overload that also specifies the wait duration and sleep values. A lot of the time I think we don't care to change those defaults and just want a good error message. This new overload allows for that.I did not triage or change any existing usages to be replaced by this new overload since I did not want to assume case by case that we intended to keep those mentioned values default even when they were the same value. This new method is just a convenience for future use.
I also fixed some typos and tightened some of the javadoc comments while I was editing this file.