Skip to content

Log information about wal entries and size when closed #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlmarion merged 2 commits into from
Oct 1, 2026
Merged

Log information about wal entries and size when closed #6569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e528b9
Log information about wal entries and size when closed
dlmarion Sep 30, 2026
dd0712b
Updated method name
dlmarion Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,11 +1425,10 @@ public void walogClosed(DfsLogger currentLog) throws WalMarkerException {
closedLogs.add(currentLog);
clSize = closedLogs.size();
}
log.info("Marking " + currentLog.getPath() + " as closed. Total closed logs " + clSize);
log.info("Marking {} as closed. Total closed logs: {} ", currentLog.getPath(), clSize);
walMarker.closeWal(getTabletSession(), currentLog.getPath());
} else {
log.info(
"Marking " + currentLog.getPath() + " as unreferenced (skipping closed writes == 0)");
log.info("Marking {} as unreferenced (skipping closed writes == 0)", currentLog.getPath());
walMarker.walUnreferenced(getTabletSession(), currentLog.getPath());
}
}
Expand Down
6 changes: 6 additions & 0 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -567,6 +568,11 @@ public synchronized long getWrites() {
return writes;
}

public synchronized long getBytesWritten() {
Objects.requireNonNull(logFile, "logFile is null");
return logFile.getPos();
}

public LoggerOperation defineTablet(CommitSession cs) throws IOException {
// write this log to the METADATA table
final LogFileKey key = new LogFileKey();
Expand Down
4 changes: 3 additions & 1 deletion server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ public void run() {
// it's possible the log was advertised in ZK even though we got an
// exception. If there's a chance the WAL marker may have been created,
// this will ensure it's closed. Either the close will be written and
// the GC will clean it up, or the tserver is about to die due to sesson
// the GC will clean it up, or the tserver is about to die due to session
// expiration and the GC will also clean it up.
try {
tserver.walogClosed(alog);
Expand Down Expand Up @@ -371,6 +371,8 @@ private synchronized void close() throws IOException {
if (currentLog != null) {
try {
currentLog.close();
log.info("Closing write-ahead log: {}, entries written: {}, bytes written: {}",
currentLog.getFileName(), currentLog.getWrites(), currentLog.getBytesWritten());
} catch (DfsLogger.LogClosedException ex) {
// ignore
} catch (Exception ex) {
Expand Down
Loading