Skip to content

Fix importdirectory command description layout - #6562

Merged
dlmarion merged 2 commits into
apache:mainfrom
efegokdemir:codex/issue-6544-import-description
Sep 29, 2026
Merged

dlmarion merged 2 commits into
apache:mainfrom
efegokdemir:codex/issue-6544-import-description

Conversation

@efegokdemir

Copy link
Copy Markdown
Contributor

Summary

  • Remove the embedded line break from the importdirectory command description so the shell formatter keeps the continuation aligned.
  • Add a regression test covering the description output.

Testing

  • mvn -pl shell -am -Dtest=ImportDirectoryCommandTest -DfailIfNoTests=false -DskipFormat test — passed with Java 21.
  • mvn -pl shell -am -DskipTests -DverifyFormat verify — passed with Java 21.
  • git diff --check — passed.

Fixes #6544

Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>

@utafrali utafrali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly removes the embedded newline and the regression test properly asserts against the actual newline character. One minor defect: replacing \n with a trailing space introduces a double space where the next concatenated string literal also begins with a space.

@dlmarion
dlmarion merged commit 1aec303 into apache:main Sep 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportDirectoryCommand description not displaying correctly

3 participants