fix buffered inline comment delivery failures - #1681
Open
lakshayxi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679.
Buffered inline comment delivery failures were logged but otherwise ignored, so a review could report
Posted 0/Nand still succeed.This change makes failed posts visible with GitHub Actions error annotations and preserves dropped comment bodies in the logs. Partial delivery remains non-fatal so successfully posted findings are still usable, while a complete
0/Ndelivery failure exits non-zero after all comments have been attempted.Tests cover successful delivery, partial and total failures, GitHub 422 diagnostics, multiline comment logging, and unserializable API error data.
Validation:
bun test test/post-buffered-inline-comments.test.tsbun testbun run typecheckbun run format:checkgit diff --check