Skip to content

fix buffered inline comment delivery failures - #1681

Open
lakshayxi wants to merge 1 commit into
anthropics:mainfrom
lakshayxi:fix-buffered-inline-comment-delivery
Open

fix buffered inline comment delivery failures#1681
lakshayxi wants to merge 1 commit into
anthropics:mainfrom
lakshayxi:fix-buffered-inline-comment-delivery

Conversation

@lakshayxi

Copy link
Copy Markdown

Fixes #1679.

Buffered inline comment delivery failures were logged but otherwise ignored, so a review could report Posted 0/N and still succeed.

This change makes failed posts visible with GitHub Actions error annotations and preserves dropped comment bodies in the logs. Partial delivery remains non-fatal so successfully posted findings are still usable, while a complete 0/N delivery failure exits non-zero after all comments have been attempted.

Tests cover successful delivery, partial and total failures, GitHub 422 diagnostics, multiline comment logging, and unserializable API error data.

Validation:

  • bun test test/post-buffered-inline-comments.test.ts
  • bun test
  • bun run typecheck
  • bun run format:check
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

post-buffered-inline-comments exits 0 after failing to post every comment (Posted 0/N goes green)

1 participant