Skip to content

Validate fill batch size - #67

Closed
dajiaohuang wants to merge 1 commit into
ankane:masterfrom
dajiaohuang:fix/positive-fill-batch-size
Closed

dajiaohuang wants to merge 1 commit into
ankane:masterfrom
dajiaohuang:fix/positive-fill-batch-size

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Reject zero, negative, and fractional --batch-size values before table lookup or database access.
  • Prevent zero-size arithmetic failure and negative-size non-progressing fill loops.
  • Add focused tests for invalid and valid batch sizes without a database.

Validation

  • ruby -I lib test/fill_validation_test.rb — 2 runs, 9 assertions, passed (Ruby 3.4.12; task-local gems).
  • The full suite was not run because the project suite requires a PostgreSQL database; no database was used for this change.

@ankane ankane closed this in 786baa4 Oct 24, 2026
@ankane

ankane commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Thanks @dajiaohuang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants