fix(@angular/ssr): ensure public directory containment in CommonEngine - #33958
Merged
alan-agius4 merged 1 commit intoAug 28, 2026
Merged
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the path traversal prevention logic in the Angular SSR CommonEngine by replacing the startsWith(normalize(publicPath)) check with a check using relative(publicPath, pagePath). It also moves this validation step to run before checking if the page is pre-rendered. The feedback highlights a potential issue where checking relativePath.startsWith('..') can cause false positives for valid files or directories starting with .. (e.g., ..hidden), and suggests a more robust check that accounts for path separators.
Ensure that paths resolved in `retrieveSSGPage` strictly remain within the configured `publicPath` by checking `relative()` containment before evaluating the static file. Previously, a string `startsWith()` check was used, which could match sibling directories that share the same name prefix as `publicPath`.
alan-agius4
force-pushed
the
fix-common-engine-path-containment-21.2.x
branch
from
August 28, 2026 07:57
c45c6c3 to
523e60d
Compare
clydin
approved these changes
Aug 28, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that paths resolved in
retrieveSSGPagestrictly remain within the configuredpublicPathby checkingrelative()containment before evaluating the static file.Previously, a string
startsWith()check was used, which could match sibling directories that share the same name prefix aspublicPath.