Skip to content

build: update all non-major dependencies - #33945

Open
alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33939
Open

build: update all non-major dependencies#33945
alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33939

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

See associated pull request for more information.

@alan-agius4
alan-agius4 requested a review from clydin August 27, 2026 08:23
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Aug 27, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies across multiple package.json files (including eslint, rollup, listr2, picomatch, and tar-stream) and introduces type casting in tests/e2e/utils/tar.ts to resolve TypeScript compilation issues. Feedback was provided on tests/e2e/utils/tar.ts regarding stream error handling, pointing out that .pipe() does not forward errors down the pipeline, which could lead to unhandled promise rejections or test hangs. It is recommended to register error handlers on all streams in the pipeline.

Comment thread tests/e2e/utils/tar.ts Outdated
See associated pull request for more information.

Closes angular#33939 as a pr takeover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant