Repository navigation
Fix: fill <span class="title"> placeholder in header/footer templates - #7
Open
mahdyarief wants to merge 1 commit into
Open
mahdyarief wants to merge 1 commit into
mahdyarief wants to merge 1 commit into
Conversation
Chromium's print header/footer only auto-fills .pageNumber, .totalPages, and .date. A custom header that relies on a <span class="title"></span> placeholder therefore renders an empty title. Manually fill it with the resolved document title (frontmatter > --title > filename). The title is HTML-escaped so a hostile or accidental title cannot break the header markup. Extracted into src/utils/header-template.ts and covered by tests/contract/header-title.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pageNumber,.totalPages, and.date. A custom header/footer that relied on a<span class="title"></span>placeholder therefore rendered an empty title.title>--title> filename).src/utils/header-template.tsand covered bytests/contract/header-title.test.ts.Test plan
tests/contract/header-title.test.ts(6 cases: fill, page-number coexistence, footer, HTML-escape, undefined passthrough, no-placeholder passthrough)🤖 Generated with Claude Code