Skip to content

AMDSMI CPER utf-8 serialization issue fix - #311

Merged
amd-etannant merged 2 commits into
developmentfrom
amd/bugfix/amdsmi_cper_crash_fix
Oct 8, 2026
Merged

amd-etannant merged 2 commits into
developmentfrom
amd/bugfix/amdsmi_cper_crash_fix

Conversation

@amd-etannant

@amd-etannant amd-etannant commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • AmdSmiPlugin crashed in DataModel.log_model whenever amd-smi returned a CPER. cper_data is a list[FileModel], and Pydantic JSON mode encoded those bytes as UTF-8. Byte 6 of a CPER header is 0xFF, which raised PydanticSerializationError and aborted the collector before analysis.

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

@amd-etannant
amd-etannant merged commit c863d26 into development Oct 8, 2026
7 checks passed
@amd-etannant
amd-etannant deleted the amd/bugfix/amdsmi_cper_crash_fix branch October 8, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants