Repository navigation
Feature/redfish clear logs - #310
Open
amd-ansonyim wants to merge 4 commits into
Open
amd-ansonyim wants to merge 4 commits into
amd-ansonyim wants to merge 4 commits into
Conversation
Adds opt-in post-collection log clearing to RedfishEndpointCollector via a new clear_log_uris collection arg. Each URI is POSTed with an empty body after all GETs succeed. Failures downgrade the result to WARNING without affecting the collected data. New utility module nodescraper/connection/redfish/redfish_clear_log.py provides discovery (discover_clear_log_endpoints) and execution (clear_redfish_logs) following ARC's RedfishTool pattern: - Skips OverWritePolicy=NeverOverWrites stores - Continues on individual failures - Includes BMC response body in error messages for diagnosis Base layer additions: - RedfishPostResult model (mirrors RedfishGetResult) - RedfishDataCollector._run_redfish_post() helper New collection_args fields: - clear_log_uris: list[str] - explicit ClearLog action URIs to POST to Result message format: Collected N endpoint(s)[; cleared M log store(s)][; K log store(s) failed to clear] Tests: 43 new unit tests across test_redfish_clear_log.py and test_redfish_endpoint_collector.py.
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogService.ClearLogon event-type services (EventLog, FaultLog, Journal) clears accumulated entries — effective for deduplicationLogService.ClearLogon dump/diagnostic services (DiagLogs, Dump, Manager) clears bundle entry references; the nextCollectDiagnosticDataproduces a fresh dump from current system stateTest plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist