Skip to content

Amd/feature/esv3 amd smi plugin coverage gap - #307

Open
soskuei wants to merge 11 commits into
developmentfrom
amd/feature/esv3-amd-smi-plugin-coverage-gap
Open

soskuei wants to merge 11 commits into
developmentfrom
amd/feature/esv3-amd-smi-plugin-coverage-gap

Conversation

@soskuei

@soskuei soskuei commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • added real models for dict[str, ValueUnit] dictionaries in amdsmidata models. so it enforced a value shape and catching dropped rails (which dicts cannot because a dict[str, Any] would accept anything, and things like rail disappearance, renaming, or returning a string instead of temp would report nothing)
  • added --cpu / --core commands. metric --cpu all --json and metric --core all --json plus models.
  • added two commands for amd-smi node and amd-smi fabric. NODE_TOTAL_POWER, GTT_SIZE, FABRIC_INFO and FABRIC_TOPOLOGY were uncollected.

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

@soskuei
soskuei requested a review from graepaul October 6, 2026 22:32
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests plugins-inband labels Oct 6, 2026
@soskuei soskuei self-assigned this Oct 6, 2026
@soskuei

soskuei commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

left as draft as I have not tested it on a system yet. waiting on system assignment. will update once tested

@alexandraBara alexandraBara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the doc changes in PLUGIN_DOC.md, we will let the automated plugin generator workflow update that file. the one you have rewritten here is inconsistent and contains changes outside the scope of this branch.

Comment thread nodescraper/plugins/inband/amdsmi/amdsmidata.py
This reverts commit 2f66462.
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Oct 7, 2026
@soskuei
soskuei requested review from alexandraBara and removed request for alexandraBara October 7, 2026 16:40
@soskuei

soskuei commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

left as draft as I have not tested it on a system yet. waiting on system assignment. will update once tested

tested on system works as expected

@soskuei
soskuei marked this pull request as ready for review October 8, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants