Skip to content

fix: polish component states, focus rings, and alignment - #161

Merged
francoischalifour merged 1 commit into
mainfrom
fc/data-app-ui-ux-polish-07a928
Nov 18, 2026
Merged

francoischalifour merged 1 commit into
mainfrom
fc/data-app-ui-ux-polish-07a928

Conversation

@francoischalifour

Copy link
Copy Markdown
Member

A UI/UX pass over the React SDK components, focused on making every state of every control look the same and never break.

Focus rings never get cut off

Rings were clipped wherever a control sat inside a scrolling or rounded container: the page tabs, the widget "Chart / Summary" and sheet "Glossary / Queries" tabs, bar chart bars, and the live control.

  • Scrolling containers (tab lists, bar charts) now reserve ring room inside their scrollport and cancel it with a negative margin, so nothing moves. scroll-padding keeps that room when keyboard focus scrolls an item into view. The underline tab divider is painted under the tabs instead of being a border, so it keeps the content width.
  • Segments that sit flush inside a track (segmented tabs, segmented control, live control, the search clear button) use the existing data-atbl-focus="inset" and concentric corners.
  • apps-focus-rings.test.ts tabs through these controls and fails when any clipping ancestor cuts a ring, including at rounded corners. It fails on the previous styles.

The shared state layer lives in the atbl.interaction cascade layer, so component CSS cannot override state paint directly. Fixes go through the data-atbl-* attributes and the --atbl-control-* tokens instead.

One look per control

  • Segmented tabs and the segmented control had drifted into different radii, gaps, padding, and selected treatments. They now share one track with a raised selected segment (SegmentedTabList / SegmentedTab, internal). Hovering a segment no longer looks like selecting it.
  • Buttons: an open primary trigger rendered white on white, and an open ghost trigger looked idle. Both now have open and selected tokens. Primary paints with --atbl-accent / --atbl-on-accent, which default to the previous colors, so a brand accent now reaches primary buttons too.
  • Hover fill on focus: controls no longer fill on React Aria's data-focused, which also fires on pointer focus and left triggers looking stuck after a popup closed. Options still fill on virtual focus.
  • Disabled fields: a disabled search or date field now dims like other disabled controls.
  • Date picker: the input takes the shared text-control size, including the 16px touch minimum. Days, presets, help chips, and reset now use the shared surfaces, so they get hover and pressed states. Range ends use the accent color. The one-off invalid tint is removed.
  • Dropdowns: Export and Live use the shared popover surface, item radius, and item gap.
  • Chart legends: the pie legend's open state now shows, legend actions get a hover state, and all dimmed series share one opacity.
  • Typography: labels share one style (muted label size, label weight above a control, meta weight beside it). Hard-coded font weights map to the type tokens.
  • Radio and checkbox marks share size, gap, and hover.
  • Icons default to --atbl-control-icon-size.
  • Other states:
    • Spinners pulse instead of freezing under reduced motion.
    • The refresh cancel affordance appears on keyboard focus.
    • Forced-colors mode outlines the selected item.
    • Mobile sheet paddings use the space tokens.
    • Controls no longer select their label text on press or double-click; fields stay selectable.

Alignment

  • Table text starts at the widget heading edge (outer cells drop their outside padding). The pie legend text lines up the same way.
  • In filter rows, a field with a label above no longer sits 11.7px below its neighbours: rows align to the control edge. The live control is now 38px tall like the rest of the row.

Fixes

  • Pressing an open calendar month or year select again closed the whole calendar. While it is open, React Aria lays an underlay over the page, and the date picker's outside-press handler treated a press on it as leaving the calendar. Now that press only closes the nested select. Covered by a new test in apps-datetime.test.ts.
  • The widget loading label reads "Loading" instead of "Loading widget".

Left out

  • The line chart legend still starts 5px right of the heading (Recharts' default left margin). Removing that margin shifts the plot and changes nearest-point inspection in apps-chart-inspection.test.ts, so it needs its own change.
  • A shared popover entry animation was dropped. Any animation on a React Aria popover makes it wait for an exit animation, and menus stopped closing on Escape.

Keep keyboard focus rings whole inside scrolling and rounded containers,
unify segmented tabs and controls, route state paint through the shared
control tokens, align tables and labels with their headings, and keep a
pressed calendar month or year select from closing the calendar.

@albert20260301 albert20260301 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the focus-ring and nested calendar-select fixes, plus controls, chart inspection, views and export (79 local browser tests). Desktop/mobile light/dark interaction probes, packed consumers and all three starters pass; mobile date text retains its 16px floor.

@robinvrd robinvrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francoischalifour
francoischalifour merged commit 202074e into main Nov 18, 2026
13 checks passed
@francoischalifour
francoischalifour deleted the fc/data-app-ui-ux-polish-07a928 branch November 18, 2026 17:36
francoischalifour pushed a commit that referenced this pull request Nov 19, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.78.0](v0.77.0...v0.78.0)
(2026-11-19)


### ⚠ BREAKING CHANGES

* **apps:** unify local setup with shared app declarations
([#159](#159))
* run embedded page actions from the host
([#151](#151))

### Features

* improve data app starters and chart exploration
([#162](#162))
([c57a557](c57a557))
* run embedded page actions from the host
([#151](#151))
([8e496b8](8e496b8))
* show horizontal grids by default on Cartesian charts
([#157](#157))
([bfd12a7](bfd12a7))


### Bug Fixes

* correct comparison math, date range edge cases, and stale docs
([#154](#154))
([6ec7c6b](6ec7c6b))
* polish component states, focus rings, and alignment
([#161](#161))
([202074e](202074e))
* resolve packed manifest dependency before publication
([#158](#158))
([75f57eb](75f57eb))
* stacked bar tooltip inspection across sparse hourly data
([#156](#156))
([e917ff0](e917ff0))


### Code Refactoring

* **apps:** unify local setup with shared app declarations
([#159](#159))
([dec99a2](dec99a2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants