Skip to content

fix: preserve own filter keys and reject manifest prototype setters - #160

Closed
albert20260301 wants to merge 1 commit into
altertable-ai:mainfrom
albert20260301:fix/prototype-data-keys-20261118
Closed

albert20260301 wants to merge 1 commit into
altertable-ai:mainfrom
albert20260301:fix/prototype-data-keys-20261118

Conversation

@albert20260301

Copy link
Copy Markdown
Contributor

Summary

Fixes two data-loss cases found while reviewing #159 (now merged):

  • Restore the manifest extractor/override rejection of literal __proto__ prototype setters. The extractor otherwise reports an own query which the emitted JavaScript never registers.
  • Preserve own filter names in operation parsing, browser request resolution, and cross-operation filter combination with prototype-free accumulators. A computed own __proto__ filter now reaches the operation, and conflicting declarations are rejected.

This keeps #159's shared local app API and type simplification. It does not introduce computed-key syntax into the static manifest format.

Verification

Five new public API regression cases fail on merged main: bare/quoted manifest setters, override emission, operation input, and conflicting operation filters.

bun run check passes with the pinned Bun 1.4.4: static gates, all 1,198 tests across 92 files, seven packed archives and their external consumers/preview lifecycles, and all three starters.

No companion backend deployment or package publication is claimed.

@francoischalifour

Copy link
Copy Markdown
Member

@albert20260301 I think it's too much of an edge case and some kind of defensive programming.

@albert20260301

Copy link
Copy Markdown
Contributor Author

Understood. I’ll leave this closed and won’t pursue these prototype-key edge cases further without a concrete consumer report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants