Repository navigation
fix: preserve own filter keys and reject manifest prototype setters - #160
Closed
albert20260301 wants to merge 1 commit into
Closed
albert20260301 wants to merge 1 commit into
albert20260301 wants to merge 1 commit into
Conversation
Member
|
@albert20260301 I think it's too much of an edge case and some kind of defensive programming. |
Contributor
Author
|
Understood. I’ll leave this closed and won’t pursue these prototype-key edge cases further without a concrete consumer report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two data-loss cases found while reviewing #159 (now merged):
__proto__prototype setters. The extractor otherwise reports an own query which the emitted JavaScript never registers.__proto__filter now reaches the operation, and conflicting declarations are rejected.This keeps #159's shared local app API and type simplification. It does not introduce computed-key syntax into the static manifest format.
Verification
Five new public API regression cases fail on merged main: bare/quoted manifest setters, override emission, operation input, and conflicting operation filters.
bun run checkpasses with the pinned Bun 1.4.4: static gates, all 1,198 tests across 92 files, seven packed archives and their external consumers/preview lifecycles, and all three starters.No companion backend deployment or package publication is claimed.