Repository navigation
feature detection - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary CMake builds could leave existing small-prime FFT and CRT/export optimizations disabled, even on supported hardware. The kernels require AVX2/FMA and, for the eight-lane paths, AVX512F/DQ. The previous configuration did not consistently propagate these complete requirements to downstream targets linking crypto3::math.
This change:
• Reuses CPU/OS and compiler checks to enable complete supported instruction bundles.
• Exports the required flags through crypto3::math, keeping IFMA detection independent of DQ.
• Refreshes feature detection during reconfiguration and preserves unsupported-host and cross-compilation fallbacks.
• Documents configuration requirements and binary portability limits.
• Adds opt-in consumer tests checking actual kernel-selection macros and transitive flags. Numerical correctness tests alone would not detect silently disabled optimizations.