Repository navigation
Factorization optimization: Emit factors incrementally and add optional small-degree screening - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains two changes to when factorization performs work and delivers factors.
Previously, complete factorization discovered all degree groups, then split them into irreducible factors and called the callback. Now, whenever it discovers a group, it immediately splits that group and calls the callback after each irreducible factor. If the callback requests a stop, both splitting and further degree discovery stop.
This lets norm recovery reject H as soon as it encounters an unsuitable odd-multiplicity factor. Even multiplicities retain their existing handling.
The new option is:
options.distinct_degree_screening_limit = 1;A positive limit screens small degrees before constructing the full Kaltofen–Shoup baby-step table. Screening reuses the initial Frobenius power, and its computed powers become the table prefix if factorization continues. The default remains zero.With this setting, for each nonlinear square-free part B, the algorithm:
- Computes X^Q mod B and prepares the initial Frobenius composition cache.
- Computes gcd(B, X^Q − X), obtaining the group of linear factors.
- Splits that group and immediately invokes the factor callbacks.
- Stops if a callback rejects. Otherwise, removes the classified group and continues with the normal blocked search, reusing the Frobenius powers already computed.