Repository navigation
Feat/schema field rename - #363
Merged
Merged
Conversation
EventID -> eventID, logFormatVariables -> headerVariables, alertsObtain -> alertDetails, extractedTimestamps -> logTimestamps, detectionTimestamp -> detectedTimestamp, outputTimestamp -> aggregatedTimestamp, __version__ -> schemaVersion. Field numbers and types are unchanged, so the binary wire format stays. Breaking: no aliases for the old names. Refs #127 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts the __version__ -> schemaVersion part of the rename. The schema version value stays at 2.0.0 for the other six renames. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apply the field rename to code that came in with development (alert aggregation templates, alerts.json fixture, basic_concat). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viktorbeck98
marked this pull request as ready for review
October 14, 2026 08:14
ipmach
requested changes
Oct 15, 2026
ipmach
left a comment
ipmach
left a comment
Contributor
There was a problem hiding this comment.
This is a little problematic because we have a demo coming soon, so it is important that before that:
- DetectMateService does not raises errors.
- Alina and Lukas codes do not stop working.
Can you make sure that everyone is ok with this change?
Contributor
There was a problem hiding this comment.
this is redundant, it should be delete it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ipmach
approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
def deserialize(schema_class: SchemaT, message: bytes) -> SchemaT:I think this function should have an error raise if the receive an schema 1.0.0. Because 2.0.0 is not backward compatible
viktorbeck98
added a commit
that referenced
this pull request
Oct 15, 2026
Follow the schema field rename (#363) in the JsonParser fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viktorbeck98
added a commit
that referenced
this pull request
Oct 15, 2026
Follow the schema field rename (#363) in the docs changes, keep the config Field descriptions and add one for deduplicate_values, and regenerate the configuration argument tables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Description
How Has This Been Tested?
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need.