Repository navigation
Development to 0.6.1 - #351
Merged
Merged
Conversation
Docs/minor fixes
The detector trained and checked only the first instance of an event, and auto-configuration wrote the instances in the order the variables arrived. A ParserSchema keeps its logFormatVariables in a protobuf map with no fixed order, so the monitored combination, and with it the results, changed from run to run. - train and check every instance of an event on its own; a log that lacks one of an instance's variables is skipped for that instance - sort variables and combos before set_configuration writes the config - VariableDetector gets an _event_variables hook; its default is unchanged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The three real-data tests pinned the logs flagged by the first combination only. The detector now checks all 28 configured combinations, so the logs with an unseen value pair in any of them are expected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viktorbeck98
approved these changes
Oct 13, 2026
fix: make NewValueComboDetector use every configured combination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Description
How Has This Been Tested?
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.