fix(layout): place a square-wrapped object after text on its first line from the paragraph's top - #394
Merged
airmang merged 1 commit intoOct 2, 2026
Conversation
…ne from the paragraph's top A square-wrapped object whose control follows text in its paragraph was unsupported. Hancom places such an object from the top of the line its control falls on, the paragraph laid out the column's whole width: on the first line that is the paragraph's top, as for an object before the text, and the lines reaching its band go beside it, the paragraph's own included. The estimate now follows that when FormFit puts the control on the paragraph's first line; past it, the object stays unsupported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
deleted the
fix/page-estimate-square-object-after-text-on-the-first-line
branch
October 2, 2026 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
쪽 수 추정(실험,
estimate_pages)이 문단 글 뒤에 놓인 어울림(SQUARE) 개체를 지원 밖(... wrapped square after text)으로 두던 것을, 그 개체의 조판 부호가 문단 첫 줄에 있을 때 고친다._on_first_line이 문단을 단 전체 폭에서 FormFit으로 나누어 부호가 첫 줄에 있는지 본다._square_object가 개체를 글 앞 개체처럼 돌려준다.테스트
tests/test_layout_page_estimate.py의HANCOM_PAGES에 한/글 저장본 셋을 더한다. 캐시가 있을 때와 없을 때를 모두 시험한다.test_a_square_object_after_text_past_the_first_line_is_not_followed: 부호가 60자 뒤라 전체 폭으로 둘째 줄인 저장본이다. 한/글은 그 줄 윗선(9600)에서 잰다. 아직 지원 밖임을 단언한다.🤖 Generated with Claude Code