fix(layout): split a square-wrapped table over the page end as Hancom does - #389
Merged
Merged
Conversation
… does A table wrapped square, flowing with the text and allowed to split, whose band passed the body's foot was followed only through the layout caches. Hancom splits it over the page end as a flowing table, between rows or cell lines, and the lines on each page it reaches go beside its part there: on its first page from its top to the foot, on a page it fills all of them, on its last page from the top down to its end. Without the caches the section is now laid out again with the table flowing as a flowing table and its bands set page by page, the lines reaching them broken again beside them. A page may hold two such bands (one table's end and another's start); a paragraph reaching both is not followed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
쪽 수 추정(실험,
estimate_pages)이 글과 함께 움직이고 나뉠 수 있는 어울림(SQUARE) 표가 본문 바닥을 넘을 때, 줄 캐시가 없으면 지원 밖(a square-wrapped or offset top-and-bottom object past the page foot)으로 두던 것을 고친다._spans)._Paginator._span_bands)는 그 문단을 놓을 때 표를 흐르는 표처럼 흘려(_flow_table) 걸친 쪽을 구하고, 쪽마다 표 부분의 띠를 둔다._at_band).테스트
tests/test_layout_page_estimate.py의HANCOM_PAGES에 한/글 저장본 여섯을 더한다(캐시 있음·없음). 표는 2열이고 단 왼쪽에 두었다. 10pt 글에 줄 간격 160%다.test_a_square_object_past_the_page_foot_goes_on_at_the_next_pagepages_table_square_past_the_page_foot)도 이제 캐시 없이 한/글과 같다. 그래서 매개변수followed를 없앴다.🤖 Generated with Claude Code