Repository navigation
feat: use safe block finality for L2 syncers - #1902
arnaubennassar wants to merge 2 commits into
Conversation
BridgeL2Sync and L2GERSync default BlockFinality moves LatestBlock ->
SafeBlock so the L2 syncers no longer index blocks that may still be
reorged; ClaimL2Sync picks the new value up via its
{{BridgeL2Sync.BlockFinality}} reference.
…dk-erigon
The multi-chains CDK Erigon e2e job failed after the SafeBlock default
change: the kurtosis cdk-erigon L2 nodes never advance the 'safe' block
tag, so the L2 bridge syncer (and the claim syncer that inherits
{{BridgeL2Sync.BlockFinality}}) indexed zero L2 blocks and the bridge
API never surfaced L2-origin deposits — all 4 bridge-e2e-3-chains tests
timed out at get_bridge (50 attempts x 25s, empty bridges array).
Pin BlockFinality = "LatestBlock" for cdk-erigon chains only (the
template already branches on sequencer_type). OP/op-succinct chains keep
the new SafeBlock default and their e2e jobs passed with it, so the new
default stays exercised.
|
Pushed a CI fix (4392903): the multi-chains CDK Erigon e2e job was failing because |
🔄 Changes Summary
LatestBlocktoSafeBlock, so they stop indexing L2 blocks that may still be reorged. Requested by the maintainer.[BridgeL2Sync]and[L2GERSync]defaultBlockFinalitychanges fromLatestBlocktoSafeBlock(deployments that want the old behaviour can still set it explicitly).[ClaimL2Sync]needs no edit — it inherits the new value through its existing{{BridgeL2Sync.BlockFinality}}reference.📋 Config Updates
✅ Testing
go build -buildvcs=false ./...;go test -count=1 ./config/...;gofmt -l config/(clean);golangci-lint run ./config/...(0 issues).📝 Notes
docs/bridge_service.md(public-config example responses) andtest/e2e/envs/anvil-2chains/config/002/aggkit-config.tomlstill show/pin the oldLatestBlockvalue explicitly; intentionally left untouched in this PR and will need a touch-up.