Repository navigation
feat: configurable gRPC client MaxDecodingMessageSize and downgrade toBlock inconsistency log - #1900
Merged
joanestebanr merged 3 commits intoOct 8, 2026
Conversation
…ock inconsistency log - grpc.ClientConfig: new MaxDecodingMessageSize (bytes) applied via MaxCallRecvMsgSize; 0 keeps the gRPC default (4 MiB). - aggsender: log "toBlock inconsistency" at warn level only when agglayer-derived > db-stored; otherwise log at info level, since a lower derived value is expected when trailing blocks have no bridge exits. Closes #1892 Closes #1899 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
arnaubennassar
previously approved these changes
Oct 8, 2026
The check compared Etherman.L1ChainID against the rollup chain ID, which is meaningless and always warned with the default L1ChainID = 0. Closes #1518 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joanestebanr
enabled auto-merge (squash)
October 8, 2026 14:44
arnaubennassar
approved these changes
Oct 8, 2026
joanestebanr
deleted the
feat/grpc-client-max-decoding-size-and-toblock-log
branch
October 8, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
MaxDecodingMessageSizeoption (bytes) ingrpc.ClientConfig, applied withgrpc.MaxCallRecvMsgSize. Default 16 MiB;0uses the gRPC default of 4 MiB. Fixesdecoded message length too large: found 6984403 bytes, the limit is: 4194304 byteswhen requesting aggchain proofs.toBlock inconsistency for settled certlog is nowWarnonly whenagglayer-derived > db-stored. Whenagglayer-derived < db-stored(expected when the trailing blocks of a certificate have no bridge exits) it is logged atInfo. Behavior is unchanged: the derived value is always used.Incorrect ChainID in aggOracle providedwarning increateAggoracle(it comparedEtherman.L1ChainIDwith the rollup chain ID, and fired even with the defaultL1ChainID = 0).docs/etherman.mdnow recommends not settingL1ChainIDand relying on auto-discovery.📋 Config Updates
MaxDecodingMessageSize(bytes, default16777216= 16 MiB;0= gRPC default of 4 MiB) in every gRPC client section:Documented in
docs/common_config.md.✅ Testing
TestNewClient_MaxDecodingMessageSize(5 MiB response rejected with the default limit, accepted when configured);NextCertificateBlockRangecases for derived lower/higher than stored.go test ./grpc/ ./aggsender/flows/ ./aggsender/config/ ./config/🐞 Issues
MaxDecodingMessageSizefor grpc clients #1892📝 Notes
grpc.DefaultConfig()andconfig/default.go.🤖 Generated with Claude Code