Repository navigation
Conversation
Error constructor's second parameter expects ErrorOptions ({ cause }),
not a plain string. Passing keypair.curve as a string was silently
ignored, making the thrown error only say "Unsupported algorithm"
with no indication of which curve triggered it.
Replace with a template literal so the message is self-describing:
"Unsupported algorithm: secp384r1"
Consistent with the existing pattern in curveToJwtAlgorithm(), which
already uses this form.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
createJwtSigner(), thedefaultbranch throws:Error's second parameter isErrorOptions({ cause?: unknown }), not astring. Passingkeypair.curve(a plain string like"secp384r1") as the second argument is silently discarded by the runtime — TypeScript accepts it becausestringis assignable toErrorOptionsvia structural typing, but the value is never used. The thrown error therefore only says"Unsupported algorithm", with no indication of which curve is unsupported.Fix
Replace with a template literal:
This makes the error self-describing (e.g.
"Unsupported algorithm: secp384r1") and is consistent with the existing pattern incurveToJwtAlgorithm(), which already uses'Unsupported curve: ${String(curve)}'.Impact
defaultbranch has no test coverage today; this fix makes any future test trivially assertable against the message.