Repository navigation
fix(agbossjs/agboss#746): a question role's pause is read back; core at 606370a0 - #39
Merged
Merged
Conversation
…'s DTO, not a tool call Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Kh8JmysuhZyQRSpNyJdPg
…as the question pause cases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Kh8JmysuhZyQRSpNyJdPg
PavelRavvich
force-pushed
the
fix/746-question-pauses
branch
from
November 4, 2026 12:31
37e7682 to
7e08f0d
Compare
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs agbossjs/agboss#746
What changed
src/stores/framework-json.ts: the stored-pause check took everyaskfor an approval's tool call (callId,tool,summary), so a question role's pause (a flow step's, Question roles: a workflow question (@ChannelRole({ ask, answer })) that a flow step or a tool can ask agboss#659, or an agent's tool call, #712) made its execution fail reading its own pause back (a stored pause is not readable). The ask is now any object for a pause whosecomponent.kindisquestion; every other pause still needs its tool call (fails loudly as before)..agboss-version.json→ core606370a0(fix-746: a question role's pause is stored and read back on SQLite; pausedExecutionContract covers it agboss#756): itspausedExecutionContracthas the question-pause cases, sostoreConformancehere runs them.How it was tested
tests/stores/paused-execution.test.ts› "A question role's pause cannot be stored by @agboss/postgres (or @agboss/mongodb): their pause schema takes an approval's ask only, and pausedExecutionContract has no question pause agboss#746: a question's pause, whose ask is no tool call, is read back as written" — failed before the fix, green after; "an approval's pause whose ask lost its tool call still fails loudly" keeps the check strict.tests/contracts/store-conformance.test.ts› "paused execution contract (PostgreSQL) > a question role's pause, as an approval's" — 2 failed with the old schema, green with the fix..toQuestion(Role)asked on process A (status: paused,kind: question), answered on process B, which runs the next step and finishes; a second answer →NotPausedError. On main the execution died ona stored pause is not readable.npm run check: everything green buttests/contracts/explorer-bites.test.ts, which crossed its 15-minbeforeAlltimeout under machine load (same on a README-only branch at the old pin; agbossjs/postgres: tests/contracts/explorer-bites.test.ts's beforeAll crosses its 15-min hook timeout in a full local gate under load (376 s on CI, 677 s alone) agboss#760).🤖 Generated with Claude Code
https://claude.ai/code/session_012Kh8JmysuhZyQRSpNyJdPg