Repository navigation
fix(tests): wait for loaded content in live layout checks - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Live layout and interaction checks could accept loading placeholders or inert first-painted cards as ready content. In the phone profile check, the selected card had no measurable box when header geometry was compared. Require a real cast after the wallet data is present, assert that all three boxes exist, and preserve the original geometry comparisons.
Apply the same readiness rule to nine existing live cases: Home interactions wait for app handover, and CSP/phone overflow checks require loaded app cards or posts. First-paint timing, the 100 ms navigation limit, Back geometry/stability, network hooks, test identities and inline request checks are unchanged. There are no runtime, workflow, quota or database changes.
Validation
scripts/check.sh: 612 native tests, formatting, native/Wasm Clippy and licenses pass.