Skip to content

fix(ui): keep dismissed previews closed and stabilize browser checks - #331

Merged
ael-dev3 merged 2 commits into
mainfrom
fix/browser-fixture-preconditions
Oct 25, 2026
Merged

ael-dev3 merged 2 commits into
mainfrom
fix/browser-fixture-preconditions

Conversation

@ael-dev3

@ael-dev3 ael-dev3 commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Behavior

Escape-dismissed profile previews could reopen after their closing animation when layout changes generated mouse-entry events under a stationary pointer. Keep dismissal in place until a mouse or hover-capable pen deliberately moves outside the preview, while preserving keyboard, touch, nested-preview and fresh-hover behavior. A deterministic regression reproduces the old failure after the panel has fully closed and checks deliberate mouse and pen reopening.

The same batch fixes browser-fixture preconditions: preserve the first-paint stopwatch while waiting for app handover, compare Back navigation with the card position at the actual click, await exact page-load counts, and run local D1 commands asynchronously so Node 22 can retire closed pooled sockets. Unexpected upload failures retain bounded Worker diagnostics. Existing timing limits, assertions, retries, skips and workflows remain unchanged.

Validation

  • Required scripts/check.sh: 612 native tests, formatting, native/Wasm Clippy and licenses pass.
  • Related preview regressions: 44 pass, one existing declared touch-only skip, zero retries; the new layout regression fails on the old product and passes after the fix.
  • Prior focused fixture repairs: 12 real Worker upload cases under CI Node 22, 17 split-part cases, two affected live cases and 28 tooling checks pass without retries.
  • All prior 934 browser case identities are retained; the layout/pen regression adds one. Normal CI must pass cleanly before merge; recovered flakes remain rejected.

@ael-dev3 ael-dev3 changed the title fix(tests): wait for browser and upload fixture readiness fix(ui): keep dismissed previews closed and stabilize browser checks Oct 25, 2026
@ael-dev3
ael-dev3 merged commit 0e3377d into main Oct 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant