Repository navigation
fix(web): ignore queued popover closes after navigation - #327
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating from a nested profile preview can deliver a queued close after its owner is disposed, causing a WebAssembly panic while cancelling its timer. Close now ignores disposed state and timer cancellation atomically takes the live handle. A regression retains a queued close across navigation: it fails on the deployed source with the same close/cancel stack and passes with this repair.
Split the live reactions-list and feed-replies preview workflows so the existing between-test pacing drains their speculative profile reads. Every interaction assertion and the strict 60-request check remain. The separated workflows passed against production with 10 and 12 requests and no bad responses; the original 76-request failure remains retained in release evidence.
Validation: required local checks (607 native tests, formatting, Clippy including static-host, licenses), normal build, five lifecycle cases, 26 adjacent hover/touch/keyboard cases. Isolated smoothness: 70 passed, two existing declared skips, zero retries. No provider, write path, deployment trigger or performance budget changes.