Repository navigation
test: cover non-interruptive event lifecycle - #271
Open
JakkulaVeerababu wants to merge 1 commit into
Open
JakkulaVeerababu wants to merge 1 commit into
JakkulaVeerababu wants to merge 1 commit into
Conversation
Author
|
@adobe/open-source-office I completed and email-verified the Adobe CLA today, but the Adobe CLA check still reports "No signed agreements were found" after closing and reopening this PR as instructed. Could you please refresh or verify the agreement for this contributor? The same issue affects PR #270. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add coverage for the complete non-interruptive event lifecycle: an event begins in the defined state, starts through
PhasedEventManager, can be waited on until it finishes, and ends in the finished state.Related Issue
Closes #190
Motivation and Context
The existing event tests cover individual start and finish behaviors, but do not assert the state transitions together. This regression test documents the expected lifecycle for event implementations and the event manager.
How Has This Been Tested?
mvn -s C:/Users/LENOVO/AppData/Local/Temp/omnirush/maven-settings.xml -pl phased-testing-testng -am -Dtest=TestPhasedNonInterruptive -Dsurefire.failIfNoSpecifiedTests=false testmvn -s C:/Users/LENOVO/AppData/Local/Temp/omnirush/maven-settings.xml -pl phased-testing-testng -am testgit diff --checkNote: the repository's
.mvn/settings.xmlhas a leading blank line before its XML declaration, so Maven was run with a temporary empty settings file to bypass that pre-existing configuration issue.Types of changes
Checklist