Skip to content

test: cover non-interruptive event lifecycle - #271

Open
JakkulaVeerababu wants to merge 1 commit into
adobe:mainfrom
JakkulaVeerababu:test/non-interruptive-event-lifecycle-190
Open

JakkulaVeerababu wants to merge 1 commit into
adobe:mainfrom
JakkulaVeerababu:test/non-interruptive-event-lifecycle-190

Conversation

@JakkulaVeerababu

Copy link
Copy Markdown

Description

Add coverage for the complete non-interruptive event lifecycle: an event begins in the defined state, starts through PhasedEventManager, can be waited on until it finishes, and ends in the finished state.

Related Issue

Closes #190

Motivation and Context

The existing event tests cover individual start and finish behaviors, but do not assert the state transitions together. This regression test documents the expected lifecycle for event implementations and the event manager.

How Has This Been Tested?

  • mvn -s C:/Users/LENOVO/AppData/Local/Temp/omnirush/maven-settings.xml -pl phased-testing-testng -am -Dtest=TestPhasedNonInterruptive -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -s C:/Users/LENOVO/AppData/Local/Temp/omnirush/maven-settings.xml -pl phased-testing-testng -am test
  • Targeted run: 29 tests passed, 0 failures, 0 errors, 0 skipped.
  • Full module run: 418 tests passed, 0 failures, 0 errors, 0 skipped.
  • git diff --check

Note: the repository's .mvn/settings.xml has a leading blank line before its XML declaration, so Maven was run with a temporary empty settings file to bypass that pre-existing configuration issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JakkulaVeerababu

Copy link
Copy Markdown
Author

@adobe/open-source-office I completed and email-verified the Adobe CLA today, but the Adobe CLA check still reports "No signed agreements were found" after closing and reopening this PR as instructed. Could you please refresh or verify the agreement for this contributor? The same issue affects PR #270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test event method

1 participant