Skip to content

fix: preserve line endings and skip unchanged files in arabic-presentation-form - #8

Merged
adehad merged 1 commit into
mainfrom
fix/preserve-line-endings
Oct 22, 2026
Merged

adehad merged 1 commit into
mainfrom
fix/preserve-line-endings

Conversation

@adehad

@adehad adehad commented Oct 22, 2026

Copy link
Copy Markdown
Owner

arabic-presentation-form rewrote every file it checked in Python text mode, so on Windows each run converted LF files to CRLF (even when it reported Passed and changed nothing), fighting .gitattributes eol=lf and other line-ending hooks in consuming repos.

  • Read and write with newline="" so each line keeps its original ending.
  • Only write the file when a line actually changed.

Existing tests/arabic_presentation_form pass.

🤖 Generated with Claude Code

@adehad
adehad force-pushed the fix/preserve-line-endings branch from 849896f to a8b35b2 Compare October 22, 2026 21:15
@adehad
adehad merged commit e66da79 into main Oct 22, 2026
2 checks passed
@adehad
adehad deleted the fix/preserve-line-endings branch October 22, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant