Repository navigation
fix(sdk): honour update() returning value 0 in getQuote - #279
Open
AnkitSingh411 wants to merge 1 commit into
Open
AnkitSingh411 wants to merge 1 commit into
AnkitSingh411 wants to merge 1 commit into
Conversation
getQuote applied an action's update() result with a truthiness check
('if (updated?.value)' / 'if (maybePromise?.value)'), so an update()
that legitimately computed value 0 was ignored and the stale pre-quote
value was encoded into the MulticallHandler message. 0n is a valid
value — compare against undefined instead, in both the async and sync
branches.
AnkitSingh411
requested review from
amateima,
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
November 7, 2026 16:25
|
@AnkitSingh411 is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 8f5ec0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getQuote applied an action's update() result with a truthiness check
('if (updated?.value)' / 'if (maybePromise?.value)'), so an update()
that legitimately computed value 0 was ignored and the stale pre-quote
value was encoded into the MulticallHandler message. 0n is a valid
value — compare against undefined instead, in both the async and sync
branches.