Repository navigation
fix(sdk): treat depositId 0 as a valid deposit id - #277
Open
AnkitSingh411 wants to merge 1 commit into
Open
AnkitSingh411 wants to merge 1 commit into
AnkitSingh411 wants to merge 1 commit into
Conversation
depositId is a bigint/number, so 0/0n is falsy. The truthiness guards in getDeposit, waitForDepositTx, waitForAtomicTx and parseFillLogs treated depositId 0 as missing: getDeposit threw before issuing any getLogs call and the waiters threw NoDepositLogError. Deposit ID 0 is legitimate — SpokePool starts numberOfDeposits at 0 — so the first deposit on any SpokePool could not be awaited or looked up by id. Compare against undefined instead of relying on truthiness.
AnkitSingh411
requested review from
amateima,
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
November 7, 2026 16:24
|
@AnkitSingh411 is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: c40c46f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depositId is a bigint/number, so 0/0n is falsy. The truthiness guards in
getDeposit, waitForDepositTx, waitForAtomicTx and parseFillLogs treated
depositId 0 as missing: getDeposit threw before issuing any getLogs call
and the waiters threw NoDepositLogError. Deposit ID 0 is legitimate —
SpokePool starts numberOfDeposits at 0 — so the first deposit on any
SpokePool could not be awaited or looked up by id. Compare against
undefined instead of relying on truthiness.