Repository navigation
test: switch overlapping SOCKS5 listeners on a port outside the ephemeral range - #60
Merged
Merged
Conversation
…eral range overlapping_listen_addresses_on_one_port_can_be_switched took its port from 127.0.0.1:0 and then released and re-bound it while moving between 127.0.0.1 and 0.0.0.0. A parallel test binding :0 could be handed that just-released ephemeral port in between, failing the switch with EADDRINUSE (seen on ubuntu-latest in #59). Use restartable_address(), as 3a4a7bb did for the two restart tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test seen on ubuntu-latest in #59 (
Address already in use (os error 98)atmanaged_socks5.rs:141).overlapping_listen_addresses_on_one_port_can_be_switchedtook its port from127.0.0.1:0and then released and re-bound it while moving between127.0.0.1and0.0.0.0. A parallel test binding:0can be handed that just-released ephemeral port in between. It now usesrestartable_address()(a port below every ephemeral range), as 3a4a7bb did for the two restart tests; all three tests that re-bind a port now use it.Verified:
make fmt,make clippy,cargo clippy -p proxy-server --tests -D warnings, andcargo test -p proxy-server --test managed_socks5three times (16/16 each).🤖 Generated with Claude Code