[dataquery] Loading, empty and failed all look the same - #11192
Open
HenriRabalais wants to merge 1 commit into
Open
[dataquery] Loading, empty and failed all look the same#11192HenriRabalais wants to merge 1 commit into
HenriRabalais wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A query that is running but has not returned a row yet renders "Query not yet run", because the loading bar treats a count of zero as nothing having happened. A query that legitimately returns no rows says the same thing.
A stream that errors, or that closes without its terminating byte, never reaches the end of stream callback. That callback is the only thing that clears the loading flag, so the page waits forever and shows nothing.
A run whose query the user cannot access is reported with
console.error. The queries endpoint filters those out deliberately, so the condition is expected, and it fills the console on every page load.Changes
fetchDataStreamhandles a reader that reports done, and reaches the end of stream callback on every exit path.Testing Instructions
Related Issues
Covers half of #9829, the misleading state. The error message and the re-run button are in #11195.