Skip to content

[dataquery] Loading, empty and failed all look the same - #11192

Open
HenriRabalais wants to merge 1 commit into
aces:29.0-releasefrom
HenriRabalais:2026-09-04_dqt_state_reporting
Open

[dataquery] Loading, empty and failed all look the same#11192
HenriRabalais wants to merge 1 commit into
aces:29.0-releasefrom
HenriRabalais:2026-09-04_dqt_state_reporting

Conversation

@HenriRabalais

@HenriRabalais HenriRabalais commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Description

A query that is running but has not returned a row yet renders "Query not yet run", because the loading bar treats a count of zero as nothing having happened. A query that legitimately returns no rows says the same thing.

A stream that errors, or that closes without its terminating byte, never reaches the end of stream callback. That callback is the only thing that clears the loading flag, so the page waits forever and shows nothing.

A run whose query the user cannot access is reported with console.error. The queries endpoint filters those out deliberately, so the condition is expected, and it fills the console on every page load.

Changes

  • The loading bar reports progress from the first render, and stays indeterminate until there is a total to measure against.
  • fetchDataStream handles a reader that reports done, and reaches the end of stream callback on every exit path.
  • A run referencing a query that is not in the accessible list is skipped without logging.

Testing Instructions

  1. Run a query in the Data Query Tool. From the first render it should read "Loading data:" and never "Query not yet run".
  2. Open the browser console on the main page. There should be no "Could not get" entries.

Related Issues

Covers half of #9829, the misleading state. The error message and the re-run button are in #11195.

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant