Repository navigation
Feat/docker - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions CI workflow for Rust, improves code formatting and organization, and enhances robustness and testability across the codebase. The most significant changes are the addition of automated CI, improved error handling and connection logic, and the introduction of a unit test for tensor aggregation logic.
CI Integration:
.github/workflows/ci.ymlGitHub Actions workflow to automatically build, lint (withclippy), check formatting, and test the Rust project on every push and pull request tomain.Connection and Robustness Improvements:
src/main.rs, improved worker connection logic: trims and filters worker addresses, and adds retry logic (up to 5 attempts with delay) when connecting to worker nodes, making the proxy startup more robust.src/bin/client.rs, allows the proxy address to be set via thePROXY_ADDRESSenvironment variable, defaulting to[::1]:50051, improving deployment flexibility.Code Organization and Formatting:
src/main.rs,src/bin/worker.rs,src/proxy/mod.rs, andsrc/proxy/server.rs.Testing and Reliability:
test_tensor_aggregation_logicinsrc/proxy/batcher.rsto verify correct aggregation and sizing of input tensors for batching.Batching Logic Clarification:
src/proxy/batcher.rsfor better readability and maintainability.These changes collectively improve the reliability, maintainability, and testability of the codebase, and introduce automated CI for safer development.