Repository navigation
atmega: Add spi flash example - #1084
Merged
Merged
Conversation
Grazfather
force-pushed
the
atmega_flash
branch
2 times, most recently
from
October 10, 2026 16:14
019ab16 to
3b0cc13
Compare
mattnite
approved these changes
Oct 10, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Destructive operations can run against an unverified device, and erase polling may terminate before a valid erase completes.
1 open finding
What changed in this PR
Adds a W25Q128 SPI flash validation example for ATmega-based Arduino Pro Mini boards.
Changes:
- Adds JEDEC, status, erase, write, read, and verification operations.
- Provides UART diagnostics and hexadecimal formatting.
- Registers 3.3 V and 5 V Pro Mini build targets.
| File | Description |
|---|---|
examples/microchip/atmega/src/spi_flash_w25q.zig |
Implements the SPI flash example. |
examples/microchip/atmega/build.zig |
Registers new example targets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Grazfather
force-pushed
the
atmega_flash
branch
from
October 10, 2026 16:24
3b0cc13 to
875e15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example is copied from wch/ch32v, but without uart logging support, timeouts, and std formatting.