Repository navigation
docs(extract): recommend several example URLs of one page type in prepareDomain - #62
Draft
zenrows-dev-pool[bot] wants to merge 1 commit into
Draft
zenrows-dev-pool[bot] wants to merge 1 commit into
zenrows-dev-pool[bot] wants to merge 1 commit into
Conversation
…pareDomain One example URL still works, and the client still accepts 1 to 5. Several pages of the same page type give better results: Extract compares them, so it can check the fields it found and fill in fields one page is missing. Replace the old "one per kind of page" wording and show 3 product pages in the README example.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs only. The
prepareDomain()JSDoc and the README "Preparing a domain" section now tell callers to send several example URLs of the same page type:The old wording, "one per kind of page you want to extract", told callers the opposite and is removed. The README example now prepares 3 product pages of one domain instead of one listing page.
What does not change
No API or behaviour change.
exampleUrlsstill accepts 1 to 5 URLs, and the client does not reject 1 or 2.Checks
pnpm check(biome): cleanpnpm test -- --run: 500 passed, 6 skippedpnpm exec tsc --noEmit: no errorspnpm build: ok