Skip to content

fix: logic and vanilla shop item fixes - #228

Merged
Tacoman369 merged 2 commits into
Z3DR:mainfrom
GonzaloJMora:bugfix/multiple_logic_fixes
Oct 20, 2026
Merged

Tacoman369 merged 2 commits into
Z3DR:mainfrom
GonzaloJMora:bugfix/multiple_logic_fixes

Conversation

@GonzaloJMora

@GonzaloJMora GonzaloJMora commented Oct 19, 2026 •

Copy link
Copy Markdown

Found some logic/vanilla shop item issues. Here's a list of them along with problems they could cause. As a note, I did test the checks to ensure that they function and actually behave in the way I say they do.

  1. HasBottle uses changed to AnyBottle.
    • Multiple checks were never randomized since logic was always false (Milk Bar Milk and Chateau, ZH Ikana Scrub Purchase, CanBuy())
    • ZH Scrub Purchase was also missing a bottle req
    • Updated CanBuy() to also add Red Potion and Chateau Romani refills since you would need a bottle for them as well
  2. All songs wrapped in CanPlay()
    • Logic seemed to sometimes have it and sometimes not so I made sure they all matched since all songs need the ocarina.
  3. UpdateHelpers() reordered
    • Logic helpers updated out of order previously which could cause a lag that would make the search report reachable locations as unreachable
    • Removed dead AnyMagicBean assignment
    • Removed Bugs/Fish helper lines since they kept resetting events from inputs that are never sent
  4. Oath to Order now possible to be in logic after any dungeon, not just Woodfall
    • Made the logic updates so that theoretically any dungeon could be placed in logic first (in terms of Oath) since an update was made not too long ago to make the first dungeon beaten take you to the Oath check
    • Added hint for Oath
  5. General logic issues that could cause unintentional/broken seeds fixed
    • Entering Goron shrine requires only Goron mask (Goron mask kept being placed in the Goron shop, and wanted to follow what the comment next to it said)
    • Fisherman's Game now requires Song of Healing for it to be in logic: cleared Great Bay is purposefully not loaded in until both Gyorg is defeated and Mikau is healed (PR link)
    • STT upright death armos chest is never reachable so logic is now set to false (this is an inverted only check) reverted this change
    • Snowhead temple was never setting SHSwitchPress to true so logic always required 3 small keys to reach Goht despite there being a route that makes it up there without any tricks with 0 keys
    • Couple of dungeon doors saying that a small key is only required when going through a locked door on one side was fixed to require the key in both directions
    • Added hookshot route to Pirate's Fortress interior since it should be considered not a trick since the podiums are right in front of the player's face as they enter
    • Gibdo in the well updated to accept AnyMagicBean which covers getting the bean pack
    • STT Map chest needs some sort of light source to obtain the chest since its behind a light block
    • Ocean spider chest was missing fire source since two of the stalchildren are in the library which requires a fire source to get into
    • Baby Zoras check needs zora mask in order to complete the check (doesn't matter at the moment cause eggs aren't shuffled but could be a problem if that was added. this is preventative)
    • Dampe Digging needs some sort of projectile damage to defeat the big poe that spawns
    • Saving old lady with the bow just vaporizes Sakkon so I removed that
    • All night mask purchase needs you to save old lady so I added the logic for that into that check
    • Milk Bar Gorman doesn't need ocarina in order to complete that check. As long as you have all three transformation masks it triggers the check
    • Getting into the Deku Palace royal chamber now only requires Deku mask and the BeansAndWater was moved to the Imprisoned Monkey since that's the check that requires it.
  6. Fixed vanilla shop items
    • SS Potion shop vanilla red and blue potion buys were flipped (shelf indices are inverse what is visually shown in the game)
    • Goron shop item 2 was selling bombchu (10) instead of arrow (10) like the text said in game
    • All arrow buys were a tier above what the text in game promised (ie buying 10 arrows gave the player 30)
  7. Honey and Darling Days 1 and 2 were missing cExtraMinigames tag so it would show in spoiler menu

Comment thread source/location_access.cpp Outdated

@Tacoman369 Tacoman369 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I didn't know it was possible either until someone mentioned it not being the same during a no logic run lol

@Tacoman369
Tacoman369 merged commit af43b41 into Z3DR:main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants