Skip to content

fix(seasons): preview scene photos on tap instead of hover - #392

Merged
SHcommit merged 1 commit into
developfrom
feat/seasons-nearby-tap
Oct 12, 2026
Merged

SHcommit merged 1 commit into
developfrom
feat/seasons-nearby-tap

Conversation

@SHcommit

Copy link
Copy Markdown
Member

Summary

  • Hover previews on the seasons screen made the background photo flicker. Tapping or clicking a place now swaps the photo at every screen size.
  • The nearby panel shows a one-line hint ("카드를 눌러 사진 보기") to first-time visitors. Closing it stores the dismissal in localStorage (read/write wrapped in try/catch).
  • The nearby item reveal waited up to ~0.8s before text appeared; the delays are shortened to ~0.2–0.4s.

Test plan

  • npx tsc --noEmit -p . (no new errors)
  • npx vitest run src/features/seasons src/shared/components/Layout
  • Playwright on /seasons at 1440px and 390px: hover does not change the preview, tap does, the hint is dismissed and stays hidden after reload, no page errors

🤖 Generated with Claude Code

Hover previews made the background photo flicker while moving across
the cards. Tapping or clicking a place now swaps the photo at every
screen size.

- Remove the hover and focus preview handlers from place cards and
  nearby items; the nearby list buttons still switch on activation.
- Show a one-line hint ("카드를 눌러 사진 보기") in the nearby panel
  until the user dismisses it; the dismissal is stored in localStorage
  with try/catch and read after mount.
- Shorten the nearby item reveal delay (was up to ~0.8s before text
  appeared; now ~0.2–0.4s).

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: YRootLab/OnMaru-Frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7255874e-55b9-4784-b61c-5a70e73b23de

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📋 코드 리뷰 체크리스트

  • 테스트 추가/업데이트
  • 문서 업데이트
  • 콘솔 로그/디버거 없음
  • 하드코딩된 값 없음
  • 성능 고려됨
  • 보안 검토됨
  • 에러 처리 추가됨

@SHcommit
SHcommit merged commit 869e8ee into develop Oct 12, 2026
17 checks passed
@github-actions

Copy link
Copy Markdown

✅ PR 검증 통과

  • 제목 형식: ✓
  • 설명: ✓
  • 파일 수정: ✓

@github-actions

Copy link
Copy Markdown

✅ 코드 품질 검사가 완료되었습니다. 위 출력 결과에서 이슈를 확인하세요.

@github-actions

Copy link
Copy Markdown

♿ 접근성 감사가 완료되었습니다. 아티팩트의 a11y-report를 확인하세요.

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

257M .next

가장 큰 파일 상위 20개

35M .next/cache/turbopack/v16.3.5-ca2c75eb/00000014.sst
35M .next/cache/turbopack/v16.3.5-ca2c75eb/00000003.sst
33M .next/cache/turbopack/v16.3.5-ca2c75eb/00000002.sst
31M .next/cache/turbopack/v16.3.5-ca2c75eb/00000001.sst
14M .next/cache/turbopack/v16.3.5-ca2c75eb/00000011.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000013.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000009.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000007.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000005.sst
11M .next/cache/turbopack/v16.3.5-ca2c75eb/00000004.sst
6.1M .next/static/chunks/2j0lyost73yaq.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvo..js
2.7M .next/cache/turbopack/v16.3.5-ca2c75eb/00000012.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000015.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000010.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000006.sst
1.4M .next/cache/turbopack/v16.3.5-ca2c75eb/00000019.meta
1.3M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvo.
.js.map
1.3M .next/server/chunks/ssr/[root-of-the-server]__112mz-6._.js.map
1.2M .next/cache/turbopack/v16.3.5-ca2c75eb/00000020.meta

@github-actions

Copy link
Copy Markdown

⚡ Lighthouse 성능 감사가 완료되었습니다. 아티팩트에서 상세 리포트를 확인하세요.

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

257M .next

가장 큰 파일 상위 20개

35M .next/cache/turbopack/v16.3.5-ca2c75eb/00000004.sst
34M .next/cache/turbopack/v16.3.5-ca2c75eb/00000003.sst
34M .next/cache/turbopack/v16.3.5-ca2c75eb/00000001.sst
32M .next/cache/turbopack/v16.3.5-ca2c75eb/00000002.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000012.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000011.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000010.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000009.sst
12M .next/cache/turbopack/v16.3.5-ca2c75eb/00000007.sst
11M .next/cache/turbopack/v16.3.5-ca2c75eb/00000008.sst
6.1M .next/static/chunks/2j0lyost73yaq.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvo..js
2.7M .next/cache/turbopack/v16.3.5-ca2c75eb/00000015.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000016.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000014.sst
2.6M .next/cache/turbopack/v16.3.5-ca2c75eb/00000013.sst
2.1M .next/cache/turbopack/v16.3.5-ca2c75eb/00000005.sst
1.5M .next/cache/turbopack/v16.3.5-ca2c75eb/00000020.meta
1.3M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvo.
.js.map
1.3M .next/server/chunks/ssr/[root-of-the-server]__112mz-6._.js.map

@github-actions

Copy link
Copy Markdown

🔍 CodeQL 보안 분석이 완료되었습니다. 세부 검출 결과는 리포지토리의 Security 탭을 확인하세요.

@github-actions

Copy link
Copy Markdown

📊 테스트 커버리지 리포트

테스트 커버리지 요약

사용 가능한 커버리지 데이터가 없습니다.

@github-actions

Copy link
Copy Markdown

✅ E2E 테스트가 완료되었습니다. 아티팩트에서 Playwright 리포트를 확인하세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant