Skip to content

test(snapshot): cover tracked undecodable path warnings - #58

Merged
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-21-tracked-undecodable-fixture
Sep 15, 2026
Merged

nia-sg-bot merged 1 commit into
mainfrom
nia/issue-21-tracked-undecodable-fixture

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a deterministic staged fixture containing one UTF-8 and one non-UTF-8 tracked pathname
  • prove the valid file retains exact staged blob provenance while the invalid path becomes a scoped undecodable_path warning

Part of #21

Validation

  • python3 -m pytest (172 passed)
  • git diff --check

Summary by CodeRabbit

  • Tests
    • Added coverage for staged changes involving non-UTF-8 tracked paths.
    • Verified that valid modified files are still reported correctly while a scoped warning is emitted for undecodable paths.

@nia-sg-bot nia-sg-bot added roadmap Tracked on the public WildestAI roadmap priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction labels Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2bcb70db-9c89-4c19-a914-2e02104d8f7d

📥 Commits

Reviewing files that changed from the base of the PR and between 6f66953 and 4e924c9.

📒 Files selected for processing (1)
  • tests/test_git_snapshot.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change adds a test for staged snapshot resolution with an undecodable tracked path. The test verifies that the valid change is returned and the undecodable path produces one scoped warning.

Changes

Staged snapshot validation

Layer / File(s) Summary
Staged undecodable path handling
tests/test_git_snapshot.py
Adds a test that stages valid and non-UTF-8 paths, then checks the valid entry, matching OIDs, and one undecodable_path warning scoped to the undecodable path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 4e924

The change adds focused staged-path coverage, and the reported test suite and diff validation pass.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added test coverage for warnings on tracked undecodable paths.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nia/issue-21-tracked-undecodable-fixture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nia-sg-bot
nia-sg-bot merged commit 9a92507 into main Sep 15, 2026
4 checks passed
@nia-sg-bot
nia-sg-bot deleted the nia/issue-21-tracked-undecodable-fixture branch September 15, 2026 14:02
@nia-sg-bot
nia-sg-bot restored the nia/issue-21-tracked-undecodable-fixture branch September 15, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction priority:P0 Critical path / blocks a usable product roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant