Skip to content

fix(release): tolerate null merge metadata - #55

Merged
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-53-release-eligibility
Sep 13, 2026
Merged

nia-sg-bot merged 1 commit into
mainfrom
nia/issue-53-release-eligibility

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #53

Release eligibility

This PR is intentionally the reviewed release trigger: release:publish + release:patch, linked to the one same-repository release:ready, aligned roadmap issue. On merge, the tested-main workflow should create immutable tag cli-v1.1.1-<merge-sha> and dispatch the tag-only binary workflow.

Validation

  • python3 -m pytest tests/test_release_eligibility.py -q (7 passed)
  • python3 -m pytest -q (170 passed)
  • python3 -m compileall -q diffgraph scripts tests
  • release-workflow YAML parse
  • source version agreement (setup.py / diffgraph.__version__ = 1.1.1)
  • git diff --check

Compatibility

No CLI command, JSON schema, or artifact contract changes. VS Code and website compatibility/claims are unchanged.

Summary by CodeRabbit

  • Bug Fixes

    • Release eligibility checks now handle pull requests with missing or null merge-commit data without failing.
    • Incomplete metadata is treated as non-matching release evidence, allowing the check to report that no qualifying merged pull request was found.
  • Chores

    • Updated the package version to 1.1.1.
    • Added changelog documentation for the release-eligibility fix.

@nia-sg-bot nia-sg-bot added roadmap Tracked on the public WildestAI roadmap priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction release:publish Explicit request to publish the tested PR that resolves a release-ready product issue release:patch Automated CLI release: patch version bump labels Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 78466ed2-f2b6-4eba-9535-b0cad500f50b

📥 Commits

Reviewing files that changed from the base of the PR and between b11ce4b and 5c83574.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • diffgraph/__init__.py
  • scripts/release_eligibility.py
  • setup.py
  • tests/test_release_eligibility.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The release eligibility classifier now treats a null mergeCommit as non-matching. A regression test verifies the skipped result. Package metadata and the changelog now identify version 1.1.1.

Changes

Release eligibility fix

Layer / File(s) Summary
Classifier guard and regression test
scripts/release_eligibility.py, tests/test_release_eligibility.py
The classifier handles missing or null mergeCommit values without raising AttributeError. The test verifies that the result is skipped when no merged PR matches the tested SHA.
Release version metadata
diffgraph/__init__.py, setup.py, CHANGELOG.md
The package version and changelog are updated to 1.1.1. The changelog documents the incomplete metadata behavior.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 5c835

The release eligibility change safely skips incomplete pull-request metadata, preventing invalid release attempts.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #53 coding requirements are mostly implemented. docs/RELEASING.md, scripts/release_eligibility.py, and release-on-resolved-issue.yml define the label and same-repository issue path. The cl… Create the eligible reviewed merge and verify the workflow creates cli-v1.1.1-<merge-sha> without invalid prerequisites. Link the resulting immutable tag in the release notes or issue #53. Include reviewable evidence of that tag and link.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: release eligibility now tolerates null merge metadata.
Out of Scope Changes check ✅ Passed The changed files support release eligibility, release tests, changelog data, and the coordinated package version. The reviewed changes do not alter CLI behavior, graph semantics, schemas, artifacts, …
Full details: Linked Issues check

Explanation

Issue #53 coding requirements are mostly implemented. docs/RELEASING.md, scripts/release_eligibility.py, and release-on-resolved-issue.yml define the label and same-repository issue path. The classifier returns an explicit skipped result for non-release merges, fails closed for incomplete or invalid release data, and the tests cover patch, minor, major, no-release, missing bump, and invalid or missing issue cases. The PR does not demonstrate a successful immutable tag from a reviewed eligible merge or link that tag from release notes or issue #53. The changelog entry and the PR summary describe a planned release, not completed tag evidence.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nia/issue-53-release-eligibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nia-sg-bot
nia-sg-bot merged commit 1bafda5 into main Sep 13, 2026
4 checks passed
@nia-sg-bot
nia-sg-bot deleted the nia/issue-53-release-eligibility branch September 13, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction priority:P0 Critical path / blocks a usable product release:patch Automated CLI release: patch version bump release:publish Explicit request to publish the tested PR that resolves a release-ready product issue roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make immutable CLI release eligibility explicit and non-release merges green

1 participant