Fix exact indexed file identity for LSP document symbols - #5385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LSP document-symbol requests could include declarations from a case-colliding or pattern-matching indexed path, corrupting the requested document's hierarchy and ranges. Indexed lookup and the unsupported-live-extraction fallback now apply binary-equal, parameterized indexed-path selection before ordering and candidate limits.
Regression coverage checks case collisions without case-sensitive storage, literal path characters, hierarchy and identifier ranges, framed partial-result parity, and foreign declarations exceeding the materialization limit without displacing local symbols or causing false truncation. Existing live-extraction, cancellation and response-budget coverage remains in the LSP regression run.
Validation
dotnet build— passed.dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore --filter 'FullyQualifiedName~Lsp|FullyQualifiedName~SearchSymbols'— net8: 253 passed; net9: 251 passed, 2 existing conditional skips.dotnet format CodeIndex.sln --verify-no-changes --no-restore— passed.dotnet run --project tools/CodeIndex.Changelog -- check— passed.status --checkand workspace health checks — passed.origin/main..HEAD— No blocking/actionable issues found.Documentation
Updated both English and Japanese sections of
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md. Addedchangelog.d/unreleased/5382.fixed.md;CHANGELOG.mdis unchanged.Fixes #5382