Honor token boundaries in named search counts - #5383
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named-query search counts and summaries now forward
--token-boundaryto the reader. Queries such asCoverageObserverexclude longer identifiers, matching ordinary counts and named result rows while preserving count units and origin coverage.The shared regression fixture covers isolated/repeated tokens, longer identifiers, zero matches, path and origin filters, exact/substring controls, human output, and counts above the presentation limit.
Fixes #5376
Validation
dotnet test CodeIndex.sln -c Release -m:1 -p:UseSharedCompilation=false: net8.0 12,612 passed / 9 skipped; net9.0 12,118 passed / 435 skipped; zero failures.dotnet format CodeIndex.sln --verify-no-changes --no-restore --include src/CodeIndex/Cli/QueryCommandRunner.SearchRecipes.cs tests/CodeIndex.Tests/QueryCommandRunnerSearchTests.cspassed.git diff --checkpassed.origin/main..HEAD: No blocking/actionable issues found.Documentation
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/5376.fixed.md;CHANGELOG.mdis unchanged.