Preserve Python reference columns after string literals - #5381
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python string masking replaced literals with
"", shifting subsequent reference columns. Preserve their UTF-16 width sos = '😀'; 終了()records column 15 and LSP reports character 14. Repeated calls retain separate source positions, and string/comment decoys remain excluded.Bump the Python extractor contract to 3 so a normal whole-workspace index refresh repairs unchanged files written under contracts 1 or 2. No forced rebuild or schema migration is required.
Fixes #5362
Validation
--no-restore -m:1 -nr:false -p:UseSharedCompilation=false).lib.py:4:15, resolved target, one candidate.git diff --checkpassed.dotnet format whitespace CodeIndex.sln --verify-no-changes --no-restore --verbosity minimal(the command behinddev.sh lint).Documentation
docs/python-reference-coordinates.md, linked from both developer-guide sections.changelog.d/unreleased/5362.fixed.md.Adversarial review
Codex reviewed
origin/main..HEADand the subsequent whitespace-only CI fix in two rounds: No blocking/actionable issues found.