Repository navigation
Conversation
Contrary to clang 22, clang 23 will complain as soon as on the .hpp if it finds some uses of std::vector or std::floor without their corresponding #include.
Member
|
Seems like we are missing a couple other headers in the tests, would you mind fixing those as well? |
Member
|
The header missing for the tests was in wf-config. I've taken the liberty of sorting it all out in #3172 before I noticed this. Thanks for the pull request! |
Author
|
I had seen the failure occurring in wf-config, but I was unsure I wouldn't get a chicken-and-egg problem solving wf-config first; and additionally, as I started a new job, I wasn't keen on setting up a full chain on my PC… nor on blindly fixing and PRing wf-config, fearing that a fix on this first CI error could reveal a second error, then a third, and so on. So thanks for having taken charge of it all (and providing an example on how to fix those correlated CIs)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3146 with the "obvious workaround".