Repository navigation
feat(sources): name devices by MAC address in a rule, on the local network only - #105
Merged
Merged
Conversation
…twork only A rule that names an address loses its device when DHCP gives it another. SourceMatch.MACs names devices by MAC instead: a MAC whole, in any spelling, or a pattern for a maker's devices (04:03:12:*). The reader asks the neighbor table (#104) for the MAC of the address each message comes from, as it arrives; the preview and the reading again of stored messages ask the same table. A MAC is only known on this machine's own networks. Behind a router every device arrives with the router's MAC, so the table is not asked there and a rule naming MACs never matches: an address with no MAC known - routed, or not in the table yet - is no match. The editor says so under the field, in plain sight, and so do the guide and the documentation page. - When a rule names one address whose MAC is known, the editor offers to name the MAC instead. - The Devices tab finds the rule that names a device by its MAC too. - Entries that are no MAC are refused (macEntry).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #104, which is on #103. It will be retargeted to
mainonce they are merged.A rule that names an address loses its device when DHCP gives that device another address.
SourceMatch.MACslets a rule name devices by MAC instead.What a rule takes
aa:bb:cc:dd:ee:ff,AA-BB-CC-DD-EE-FF,aabb.ccdd.eeff.04:03:12:*.macEntry).Local network only, and the UI says so
Also
Tests
internal/sources:The UI was checked through the screenshot bridge: the field, the warning and the offer to name the MAC.
Checked:
go vet(Windows, Linux),staticcheck,go test -race ./...,svelte-check --fail-on-warnings,npm test,npm run build, the docs' links.